Conversation
|
Visit the preview URL for this PR (updated for commit 7cf84bc): https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app (expires Wed, 30 Jul 2025 17:47:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6915b094b5ba83fde754632ba50c1ee9406d433f |
|
I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar. |
Siegrift
left a comment
Siegrift
left a comment
There was a problem hiding this comment.
@acenolaza not sure if you saw
I'd just include it in https://oev-docs--pr210-data-feed-proxy-comb-40m36top.web.app/dapps/integration/api3-contracts.html I don't think we need the sidebar.
Sorry, missed that message. I'll apply that change |
Removed the sidebar link, added a short description and link to api3-contracts.md but I'm wondering if here wouldn't be a better place to like the data-feed-proxy-combinators repo 🤔 |
Yeah, maybe it's better to mention it after the mixed oracle design section. |
…ntract-integration.md
acenolaza
force-pushed
the
data-feed-proxy-combinators
branch
from
72be0a1 to
ef4d160
Compare
Ended up placing the text before the mixed oracle design section and right after the reading a data feed section |
Siegrift
left a comment
Siegrift
left a comment
There was a problem hiding this comment.
Final changes from me.
Siegrift
left a comment
Siegrift
left a comment
There was a problem hiding this comment.
I've changed my mind on how I like the looks of it, but approving. Once you fix this request review from Burak as he's responsible for the dApp's part of docs.
Co-authored-by: Burak Benligiray <bbenligiray@gmail.com>
3 participants
Closes api3dao/data-feed-proxy-combinators#26